Feat: Client module toggles for loading screen and UI sounds #217
Conversation
…reen and client sounds.
| if ("lambda".equals(id.getNamespace()) | ||
| && "textures/lambda_banner.png".equals(id.getPath())) { |
There was a problem hiding this comment.
I'm not sure to understand this condition here. Could you explain it ?
There was a problem hiding this comment.
During my testing, resource reload would replace the Lambda banner with a blue box rather than the vanilla banner, which was persistent across resource reloads. That check fixed it for reasons I'm unsure of, as again I was on a tight timeframe and could not look into it further. Could definitely be a local issue, I'll look into it.
…reen and client sounds.
|
Forgot to change commit message, moved the check into |
|
disabling sounds doesn't seem to disable the click gui open and close sound |
|
also i'm not sure if this is just me but if i disable the custom screen, it shows for half the time, then swaps to the mojang image |
This is due to the checks being moved into |
This is due to the way resource reload works, I briefly looked into it and was able to partially fix it (it was a blue box previously). This is something I did not have time to look into further. It only occurs on the first reload, and sometimes on the second. Subsequent reloads do not experience this bug. I can look into it more this weekend, as I will have more free time. If desired, I can hold off on pushing the changes mentioned previously until I fix the bug, and push both simultaneously. |
3 participants
I have introduced a new Client module (in the Client category) that acts as a home for toggles. The module itself has no standalone functionality; it exists solely to expose settings that gate existing client behavior. Currently, it includes a toggle to enable/disable Lambda's custom splash screen, as well as a toggle to enable/disable Lambda's UI sounds.
Due to how the splash overlay and resource reload lifecycle work, the vanilla splash screen may only be fully visible on the subsequent reload after disabling the Lambda splash screen (e.g. a second F3+T). Enabling the Lambda splash screen applies immediately.